feat(grpc): make ChildManager call the parent work_scheduler #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
force-pushed
the
child_manager_work_scheduler
branch
from
f888c3b to
c8a2166
Compare
sauravzg
reviewed
Nov 10, 2025
| // TODO: This is mainly provided as a fairly complex example of the current LB | ||
| // policy in use. Complete tests must be written before it can be used in | ||
| // production. Also, support for the work scheduler is missing. |
Collaborator
There was a problem hiding this comment.
nit: Probably need to remove todo about the missing work scheduler?
sauravzg
reviewed
Nov 10, 2025
sauravzg
reviewed
Nov 10, 2025
sauravzg
reviewed
Nov 10, 2025
sauravzg
reviewed
Nov 10, 2025
sauravzg
reviewed
Nov 10, 2025
sauravzg
reviewed
Nov 10, 2025
sauravzg
reviewed
Nov 10, 2025
sauravzg
reviewed
Nov 10, 2025
Collaborator
Author
|
I started working on all the things you commented on here, but I realized now that pretty much all of your comments should be on #2442. (See PR description:)
(And then I made one more commit on top of that "final commit" and fixed the old comment that you noticed. So please focus on just https://github.com/hyperium/tonic/pull/2443/files/f933d877c87e97a6c18cb14a86a861f9f7efe6a6..3332da3710d62e4c5999c88c3dd4a2d3884665b5 for this PR and we can carry forward the other discussions in #2442.) |
sauravzg
approved these changes
Nov 12, 2025
dfawley
force-pushed
the
child_manager_work_scheduler
branch
from
e5f8520 to
915958d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of #2442; please review only the final commit in this PR.
I found this pattern for writing tests to be painful. I will try to spend some time working on another approach.
The main problem I had with the tests was that the test_utils mod creates the
StubPolicyandStubPolicyDatameaning the tests have a hard time observing what the children Funcs did except by observing what was called on the child_controller or work_scheduler.